Skip to content

fix: perp and short transition cp-7.73.0#28689

Merged
tommasini merged 4 commits intomainfrom
fix/perps-long-short-transition
Apr 10, 2026
Merged

fix: perp and short transition cp-7.73.0#28689
tommasini merged 4 commits intomainfrom
fix/perps-long-short-transition

Conversation

@tommasini
Copy link
Copy Markdown
Contributor

@tommasini tommasini commented Apr 10, 2026 •
edited by cursor bot
Loading

Description

Fix perps and short transition

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Screen.Recording.2026-04-10.at.20.06.29.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Touches React Navigation screen options for the perps confirmation flow, which can affect modal presentation/transition behavior and header visibility across routes.

Overview
Adjusts the perps RedesignedConfirmations screen options to explicitly return StackNavigationOptions and always use presentation: 'transparentModal', while keeping the conditional perps header behavior.

This is intended to fix the perps/short transition behavior by ensuring confirmations are presented with a consistent transparent modal configuration.

Reviewed by Cursor Bugbot for commit ccdf1f4. Bugbot is set up for automated code reviews on this repo. Configure here.

@tommasini tommasini requested a review from a team as a code owner April 10, 2026 19:09
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 10, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-platform Mobile Platform team label Apr 10, 2026
@tommasini tommasini added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Apr 10, 2026
@tommasini tommasini changed the title fix: perp and short transition fix: perp and short transition cp-7.73.0 Apr 10, 2026
@github-actions github-actions bot added size-XS risk-medium Moderate testing recommended · Possible bug introduction risk labels Apr 10, 2026
@github-actions github-actions bot added size-S risk-medium Moderate testing recommended · Possible bug introduction risk and removed size-XS risk-medium Moderate testing recommended · Possible bug introduction risk labels Apr 10, 2026
gambinish
gambinish previously approved these changes Apr 10, 2026
View reviewed changes
@tommasini tommasini added this pull request to the merge queue Apr 10, 2026
@tommasini tommasini removed this pull request from the merge queue due to a manual request Apr 10, 2026
@github-actions github-actions bot added risk-medium Moderate testing recommended · Possible bug introduction risk and removed risk-medium Moderate testing recommended · Possible bug introduction risk labels Apr 10, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 10, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokePerps, SmokeConfirmations, SmokeWalletPlatform
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: medium
  • AI Confidence: 88%
click to see 🤖 AI reasoning details

E2E Test Selection:
The change in app/components/UI/Perps/routes/index.tsx has two aspects:

  1. Type-only additions (low risk): Adding StackNavigationOptions type import and explicit return type annotation to getRedesignedConfirmationsHeaderOptions — these are purely TypeScript improvements with no runtime impact.

  2. Functional navigation change (medium risk): Adding presentation: 'transparentModal' to both branches of the getRedesignedConfirmationsHeaderOptions function. This changes how the RedesignedConfirmations screen is presented within the Perps navigator — it will now render as a transparent modal overlay in both the "show perps header" and "no header" cases. This could affect the visual appearance and behavior of confirmation screens triggered from Perps flows (e.g., Add Funds deposits).

Tag selection rationale:

  • SmokePerps: Directly affected — the Perps navigation routes file is changed, specifically the confirmation screen presentation within Perps flows. The Add Funds flow (on-chain transactions) goes through this confirmation screen.
  • SmokeConfirmations: Required by SmokePerps tag description ("When selecting SmokePerps, also select SmokeConfirmations"). Also directly relevant since the presentation: 'transparentModal' change affects how the Confirm component is displayed in Perps.
  • SmokeWalletPlatform: Required by SmokePerps tag description ("When selecting SmokePerps, also select SmokeWalletPlatform"). Perps is a section inside the Trending tab.

No other tags are warranted — this change is isolated to the Perps navigation routing and its confirmation screen presentation.

Performance Test Selection:
The change adds presentation: 'transparentModal' to navigation options and type annotations. While this is a navigation behavior change, it does not affect rendering performance of lists, data loading, account/network selectors, or app startup. The transparent modal presentation is a React Navigation configuration change that doesn't introduce performance-sensitive code paths. No performance tests are warranted.

View GitHub Actions results

geositta
geositta approved these changes Apr 10, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@geositta geositta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is preferred. MarketDetails will no longer be intentionally kept attached underneath PERPS_HOME, which should reduce the risk of background work continuing while the user is on Home.

@tommasini tommasini enabled auto-merge April 10, 2026 22:31
Cal-L
Cal-L approved these changes Apr 10, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 10, 2026

✅ E2E Fixture Validation — Schema is up to date
17 value mismatches detected (expected — fixture represents an existing user).
View details

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 10, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@tommasini tommasini added this pull request to the merge queue Apr 10, 2026
Merged via the queue into main with commit 5517bff Apr 10, 2026
103 checks passed
@tommasini tommasini deleted the fix/perps-long-short-transition branch April 10, 2026 23:08
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2026
@metamaskbot metamaskbot added the release-7.74.0 Issue or pull request that will be included in release 7.74.0 label Apr 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Cal-L Cal-L Cal-L approved these changes

@geositta geositta geositta approved these changes

@gambinish gambinish gambinish left review comments

Assignees

No one assigned

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.74.0 Issue or pull request that will be included in release 7.74.0 risk-medium Moderate testing recommended · Possible bug introduction risk size-S team-mobile-platform Mobile Platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tommasini @Cal-L @gambinish @geositta @metamaskbot